[webkit-reviews] review granted: [Bug 109103] PluginProcess should quit immediately if idle in response to low-memory notifications : [Attachment 186954] fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 109103: PluginProcess should quit immediately if idle in response to
low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103

Attachment 186954: fix
https://bugs.webkit.org/attachment.cgi?id=186954&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186954&action=review


> Source/WebCore/platform/MemoryPressureHandler.cpp:55
>  void MemoryPressureHandler::respondToMemoryPressure() { }
> +
> +void MemoryPressureHandler::releaseMemory(bool) { }
>  #endif

Space between functions is strange if they are going to be all on one line like
this. Lack of space between #if/#endif and the functions is stranger.

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:137
> +    m_lowMemoryHandler(false);

Can m_lowMemoryHandler be null here? If not why not?

Separate thought: Boolean constants stink at call sites like this.

> Source/WebKit2/PluginProcess/PluginProcess.h:112
> +    static void lowMemoryHandler(bool);

Need an argument name here. It’s not at all clear what the bool is for.