[webkit-reviews] review granted: [Bug 107603] Call XSSAuditor.filterToken() from threaded HTML parser : [Attachment 186929] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 107603: Call XSSAuditor.filterToken() from threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=107603

Attachment 186929: Patch
https://bugs.webkit.org/attachment.cgi?id=186929&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186929&action=review


> Source/WebCore/ChangeLog:8
> +	   With this patch we now pass 178 of 182 tests in
http/tests/security/xssAuditor.

That's great!

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:528
> +    Settings* settings = document()->settings();
> +    bool usesEncodingDetector = settings &&
settings->usesEncodingDetector();
> +    String mimeType;
> +    if (DocumentLoader* loader = document()->loader())
> +	   mimeType = loader->responseMIMEType();
> +    String defaultTextEncodingName;
> +    if (settings)
> +	   defaultTextEncodingName = settings->defaultTextEncodingName();
> +    RefPtr<TextResourceDecoder> decoder =
TextResourceDecoder::create(mimeType, defaultTextEncodingName,
usesEncodingDetector);

Can we break this logic into a separate function that returns a
PassRefPtr<TextResourceDecoder> ?