[webkit-reviews] review granted: [Bug 107037] Get WinLauncher to compile in VS2010 (32 bit) : [Attachment 186915] WinLauncher patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 15:42:29 PST 2013

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 107037: Get WinLauncher to compile in VS2010 (32 bit)

Attachment 186915: WinLauncher patch

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186915&action=review

Looks good.  Do you think we could change the project names as I mentioned?

> WinLauncher/WinLauncher.vcxproj/WinLauncherLauncher.vcxproj:15
> +    <RootNamespace>WinLauncherLauncher</RootNamespace>

One thing I hate about this is that the executable is "WinLauncher.exe", but
the project is "WinLauncherLauncher", so you can't set this as a target and
debug directly. I wonder if "WinLauncher" could become "WinLauncherLib", and
"WinLauncherLauncher" could just be "WinLauncher"?

More information about the webkit-reviews mailing list