[webkit-reviews] review granted: [Bug 108888] Make ScrollView::paint() clip by visibleContentRect : [Attachment 186550] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 15:37:34 PST 2013


Levi Weintraub <leviw at chromium.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 108888: Make ScrollView::paint() clip by visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=108888

Attachment 186550: Patch
https://bugs.webkit.org/attachment.cgi?id=186550&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186550&action=review


> Source/WebCore/platform/ScrollView.cpp:1056
> +    IntRect visibleAreaWithoutScrollbars(location(),
visibleContentRect(false).size());
> +    documentDirtyRect.intersect(visibleAreaWithoutScrollbars);

Way cleaner, though I wish visibleContentRect took a named paramater instead of
a boolean so this was clearer :-/


More information about the webkit-reviews mailing list