[webkit-reviews] review granted: [Bug 108966] [chromium] Remove "config.h" header from WebUnitTests.cpp : [Attachment 186671] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 13:22:17 PST 2013


Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 108966: [chromium] Remove "config.h" header from WebUnitTests.cpp
https://bugs.webkit.org/show_bug.cgi?id=108966

Attachment 186671: Patch
https://bugs.webkit.org/attachment.cgi?id=186671&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186671&action=review


> Source/WebKit/chromium/tests/WebUnitTests.cpp:33
>  #include <base/test/test_suite.h>

Please add a FIXME about this include since it's a layering violation.


More information about the webkit-reviews mailing list