[webkit-reviews] review granted: [Bug 91440] Implement 'vmin' and 'vmax' from CSS3 values and units : [Attachment 185030] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 10:48:40 PST 2013


Antti Koivisto <koivisto at iki.fi> has granted Uday Kiran
<udaykiran at motorola.com>'s request for review:
Bug 91440: Implement 'vmin' and 'vmax' from CSS3 values and units
https://bugs.webkit.org/show_bug.cgi?id=91440

Attachment 185030: Updated patch
https://bugs.webkit.org/attachment.cgi?id=185030&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=185030&action=review


r=me with the tests fixed

>
LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-v
max-expected.html:19
> +<!DOCTYPE>
> +<html>
> +<style>
> + #element-container-vmax {
> +   background:green;
> + }
> +</style>
> +<div id="element-container-vmax">TEST PASSED</div>
> +<script>
> +function applyStyle() {
> +    var viewportMaxLength = Math.max(window.innerWidth, window.innerHeight);

> +    var elementStyle =
document.getElementById("element-container-vmax").style;
> +    elementStyle.height = Math.floor(30 * viewportMaxLength / 100) + "px";
> +    elementStyle.width = Math.floor(30 * viewportMaxLength / 100) + "px";
> +    elementStyle.fontSize = Math.floor(3 * viewportMaxLength / 100) + "px";
> +    elementStyle.lineHeight = Math.floor(4 * viewportMaxLength / 100) +
"px";
> +    elementStyle.textIndent = Math.floor(2 * viewportMaxLength / 100) +
"px";
> +    elementStyle.marginLeft = Math.floor(2 * viewportMaxLength / 100) +
"px";
> +    elementStyle.marginRight = Math.floor(2 * viewportMaxLength / 100) +
"px";

Your tests and result files seems to have traded places. -expected.html has
script in it.


More information about the webkit-reviews mailing list