[webkit-reviews] review granted: [Bug 109052] [Qt] Use GNU ar's thin archive format for intermediate static libs : [Attachment 186870] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 109052: [Qt] Use GNU ar's thin archive format for intermediate static libs
https://bugs.webkit.org/show_bug.cgi?id=109052

Attachment 186870: Patch
https://bugs.webkit.org/attachment.cgi?id=186870&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186870&action=review


> Tools/qmake/mkspecs/features/default_post.prf:280
> +    debug_and_release: DESTDIR = $$targetSubDir())

The old isEmpty line would still work here since you added some logic inside
targetSubDir that would return an empty string.

Looks good to me otherwise, r=me if you revert that line (and if what I'm
saying makes any sense).