[webkit-reviews] review granted: [Bug 108314] [BlackBerry] Enable non-video element enter/exit fullscreen. : [Attachment 186749] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 04:21:07 PST 2013

Antonio Gomes <tonikitoo at webkit.org> has granted Mary Wu
<mary.wu at torchmobile.com.cn>'s request for review:
Bug 108314: [BlackBerry] Enable non-video element enter/exit fullscreen.

Attachment 186749: Patch

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186749&action=review

- we have now another inconsistency: fullscreen x fullScreen. We could address
it as well in a follow up.

> Source/WebKit/blackberry/Api/WebPage.cpp:5122
> +    Element* element = static_cast<Element*>(d->m_fullscreenNode.get());

because you cast, please call 'm_fullscreenNode->isElement())

More information about the webkit-reviews mailing list