[webkit-reviews] review requested: [Bug 107682] [WK2][EFL] Unified text checker implementation : [Attachment 186818] don't call checkSpellingOfString for word separators
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 6 04:07:15 PST 2013
Grzegorz Czajkowski <g.czajkowski at samsung.com> has asked for review:
Bug 107682: [WK2][EFL] Unified text checker implementation
https://bugs.webkit.org/show_bug.cgi?id=107682
Attachment 186818: don't call checkSpellingOfString for word separators
https://bugs.webkit.org/attachment.cgi?id=186818&action=review
------- Additional Comments from Grzegorz Czajkowski <g.czajkowski at samsung.com>
This patch doesn't call checkSpellingOfString method for the word separators
(in compliance with wk-efl unit tests).
The word separators are skipped:
- at the beginning of the given text, for example
checkTextOfParagraph(' zz') -> checkSpellingOfString('zz'),
- in the middle of string, generally chechSpellingOfString finishes checking
at the word separators,
checkTextOfParagraph('zz xx') -> checkSpellingOfString('zz') and
checkSpellingOfString('xx'); (NOT checkSpellingOfString(' xx'))
- for multiple operators
checkTextOfParagraph('zz xx') -> checkSpellingOfString('zz') and
checkSpellingOfString('xx')
- at the end of the given string
checkTextOfParagraph('zz ') -> checkSpellingOfString('zz')
Morrita,
May I ask you once again to have a look at the patch. I'd appreciate your
review.
Thanks
More information about the webkit-reviews
mailing list