[webkit-reviews] review granted: [Bug 109008] AX: if <html> has an ARIA attribute, it's exposed as an AXGroup : [Attachment 186763] patch

Wed Feb 6 01:12:13 PST 2013

Ryosuke Niwa <rniwa at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 109008: AX: if <html> has an ARIA attribute, it's exposed as an AXGroup
https://bugs.webkit.org/show_bug.cgi?id=109008

Attachment 186763: patch
https://bugs.webkit.org/attachment.cgi?id=186763&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186763&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2592
> +    

Nit: spaces.

> LayoutTests/accessibility/html-html-element-is-ignored.html:20
> +	   }

It would have been helpful if you printed a message like debug("This test
requires accessibilityController"); so that a person who opened this file
manually on a browser can tell why the test is not running.