[webkit-reviews] review granted: [Bug 108933] Web Inspector: file selector list jumps as I type or move Up/Down : [Attachment 186608] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 6 00:23:55 PST 2013
Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 108933: Web Inspector: file selector list jumps as I type or move Up/Down
https://bugs.webkit.org/show_bug.cgi?id=108933
Attachment 186608: Patch
https://bugs.webkit.org/attachment.cgi?id=186608&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186608&action=review
> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:288
> + this._updateSelection(this._selectedIndexInFiltered, false);
Should we check this._selectedIndexInFiltered for null?
> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:301
> + event.consume();
Wouldn't it be better to do event.consume(true) instead?
> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:302
> + return;
These "return; break;" pairs look really weird. I would move _scheduleFilter
call to default section of this switch instead.
More information about the webkit-reviews
mailing list