[webkit-reviews] review granted: [Bug 109001] [V8] Pass an Isolate to remaining GetTemplate()s : [Attachment 186748] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 00:21:41 PST 2013

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 109001: [V8] Pass an Isolate to remaining GetTemplate()s

Attachment 186748: Patch

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186748&action=review

> Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:512
> +    v8::Isolate* isolate = v8::Isolate::GetCurrent();

V8 doesn't give us the isolate in this callback?

More information about the webkit-reviews mailing list