[webkit-reviews] review denied: [Bug 109011] File upload control doesn't apply CSS vertical padding or border to file name : [Attachment 186769] One-line fix

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Nils Barth <nbarth at google.com>'s
request for review:
Bug 109011: File upload control doesn't apply CSS vertical padding or border to
file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Attachment 186769: One-line fix
https://bugs.webkit.org/attachment.cgi?id=186769&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186769&action=review


We need a test.
I think we can't make a dumpAsText test for this change.  Probably we need a
ref test.

> Source/WebCore/rendering/RenderFileUploadControl.cpp:142
> +	   LayoutUnit textY = paintOffset.y() + borderLeft() + paddingLeft() +
buttonRenderer->baselinePosition(AlphabeticBaseline, true, HorizontalLine,
PositionOnContainingLine);

Why do you add border-left and padding-left to the vertical position?