[webkit-reviews] review canceled: [Bug 108795] INPUT_MULTIPLE_FIELDS_UI: Read-only inputs should be focusable : [Attachment 186719] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 18:03:22 PST 2013


Kent Tamura <tkent at chromium.org> has canceled Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 108795: INPUT_MULTIPLE_FIELDS_UI: Read-only inputs should be focusable
https://bugs.webkit.org/show_bug.cgi?id=108795

Attachment 186719: Patch
https://bugs.webkit.org/attachment.cgi?id=186719&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186719&action=review


>> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:-130
>> -	    return;
> 
> Is it OK to remove it? (Did you check all the call sites of
handleKeyboardEvent() ?)

I'm very sure it's ok.	I'll change this part to ASSERT(!isDisabled());

>>
LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-event
s.html:157
>> +keyDown('\t');
> 
> This test looks a bit weak to test the change. Could you test a focused
element after each action by using
internals.youngestShadowRoot(input).activeElement.getAttribute("pseudo") ? Also
it would be good to add a test for keyDown('leftArrow').

will do


More information about the webkit-reviews mailing list