[webkit-reviews] review granted: [Bug 108466] [chromium] turn TestRunner library into a component build : [Attachment 186701] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 108466: [chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Attachment 186701: Patch
https://bugs.webkit.org/attachment.cgi?id=186701&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186701&action=review


> Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:617
> -#if OS(LINUX) && USE(GTK)
> +#if defined(__linux__) && USE(GTK)

Does USE(GTK) still work?

> Tools/DumpRenderTree/chromium/TestRunner/src/config.h:35
> +#define USE(feature) (defined WTF_USE_##feature && WTF_USE_##feature)
> +#define ENABLE(feature) (defined ENABLE_##feature && ENABLE_##feature)

Ah, I see!