[webkit-reviews] review granted: [Bug 108975] [CSS Grid Layout] Grid item's logical height is not properly recomputed after -webkit-grid-column / -webkit-grid-row changes : [Attachment 186706] Proposed fix: Add the missing clear logical height override.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 14:33:59 PST 2013


Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 108975: [CSS Grid Layout] Grid item's logical height is not properly
recomputed after -webkit-grid-column / -webkit-grid-row changes
https://bugs.webkit.org/show_bug.cgi?id=108975

Attachment 186706: Proposed fix: Add the missing clear logical height override.
https://bugs.webkit.org/attachment.cgi?id=186706&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
Seems fine to me.  This is similar to what we do in flexbox.  You need to clear
override sizes right before you layout.


More information about the webkit-reviews mailing list