[webkit-reviews] review granted: [Bug 108969] formenctype to have empty string as default value. : [Attachment 186684] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 14:24:24 PST 2013

Kent Tamura <tkent at chromium.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 108969: formenctype to have empty string as default value.

Attachment 186684: patch

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186684&action=review

> LayoutTests/fast/forms/submit-form-attributes.html:23
>  input.setAttribute('formAction', 'http://localhost');
> -shouldBe('input.formAction', '"http://localhost/"');
> +shouldBeEqualToString("input.formAction", "http://localhost/");
>  input.setAttribute('formAction', 'http://localhost/');

It seems the primary quote mark in this file is single quote.  Please use
consistent quote marks.

More information about the webkit-reviews mailing list