[webkit-reviews] review granted: [Bug 108977] Make baseWritingDirectionForSelectionStart available to all platforms in the Editor class : [Attachment 186703] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 108977: Make baseWritingDirectionForSelectionStart available to all
platforms in the Editor class
https://bugs.webkit.org/show_bug.cgi?id=108977

Attachment 186703: Patch
https://bugs.webkit.org/attachment.cgi?id=186703&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186703&action=review


> Source/WebCore/editing/Editor.cpp:1345
> +	   result = LeftToRightWritingDirection;
> +	   break;

I know you're just moving an existing code but we can just return here.

> Source/WebCore/editing/Editor.cpp:1348
> +	   result = RightToLeftWritingDirection;
> +	   break;

Ditto.