[webkit-reviews] review denied: [Bug 108132] Refactor the way HAVE_XXX macros are set : [Attachment 185130] rebaseline

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Laszlo Gombos
<laszlo.gombos at webkit.org>'s request for review:
Bug 108132: Refactor the way HAVE_XXX macros are set
https://bugs.webkit.org/show_bug.cgi?id=108132

Attachment 185130: rebaseline
https://bugs.webkit.org/attachment.cgi?id=185130&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185130&action=review


Unless I missed a HAVE_DISPATCH_H, this is gonna break iOS.

> Source/WTF/wtf/Platform.h:725
> -#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
> -
> +#if OS(DARWIN) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
>  #define HAVE_DISPATCH_H 1
>  #define HAVE_HOSTED_CORE_ANIMATION 1

This will break iOS.

Do we still need __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060 actually?