[webkit-reviews] review granted: [Bug 108759] webdatabase: Introduce back-end database classes and a few small fixes : [Attachment 186659] One more time with ~DatabaseBackend() assert put back in, and ~DatabaseBackendSync() closing its own database.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 13:21:56 PST 2013


Brady Eidson <beidson at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 108759: webdatabase: Introduce back-end database classes and a few small
fixes
https://bugs.webkit.org/show_bug.cgi?id=108759

Attachment 186659: One more time with ~DatabaseBackend() assert put back in,
and ~DatabaseBackendSync() closing its own database.
https://bugs.webkit.org/attachment.cgi?id=186659&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186659&action=review


> Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp:251
> +    // SQLite is "multi-thread safe", but each database handle can only be
used
> +    // on a single thread at a time.
> +    //
> +    // For DatabaseBackendAsync, we open the SQLite database on the
DatabaseThread,
> +    // and hence we should also close it on that same thread. This means
that the
> +    // SQLite database need to be closed by another mechanism (see
> +    // DatabaseContext::stopDatabases()). By the time we get here, the
SQLite
> +    // database should have already been closed.

Good comment, thanks!


More information about the webkit-reviews mailing list