[webkit-reviews] review granted: [Bug 106989] Get WebKit projects compiling in VS2010 (32 bit) : [Attachment 186679] WebKit Projects! v2

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 106989: Get WebKit projects compiling in VS2010 (32 bit)
https://bugs.webkit.org/show_bug.cgi?id=106989

Attachment 186679: WebKit Projects! v2
https://bugs.webkit.org/attachment.cgi?id=186679&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186679&action=review


Looks good.  I propose we (you!) land it so we can use it as a base for
finalizing things.  It *might* be nice to use 'svn copy' to create some of
these files that are duplicates of the things in WebKit.vcproj, just so the SVN
history will show where they came from.  You might check with Jon or somebody
to see if that's important to them.

I don't think this patch will land automatically, since it is not prefixed by
the WebKit/Source/WebKit path, so you'll need to land it manually.

> WebKit.vcxproj/Interfaces/FixMIDLHeaders.pl:1
> +#! /usr/bin/perl -w

If this is a duplicate of the one in WebKit.vcproj, you might want to use a
'svn cp' command so that we see the history of the file (as it is 'moved' from
the VS2005 location to this new location).

> WebKit.vcxproj/WebKit/WebKitCommon.props:11
> +	 <PreprocessorDefinitions
Condition="'$(Platform)'=='x64'">WIN32</PreprocessorDefinitions>

Is this right?	Or are you just placeholding until you do a true 64-bit target?