[webkit-reviews] review granted: [Bug 72414] Entity-header extension headers honored on 304 responses. : [Attachment 186674] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 72414: Entity-header extension headers honored on 304 responses.
https://bugs.webkit.org/show_bug.cgi?id=72414

Attachment 186674: Patch
https://bugs.webkit.org/attachment.cgi?id=186674&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186674&action=review


Looks good to me.

> Source/WebCore/loader/cache/CachedResource.cpp:741
>	   // Don't allow 304 response to update content headers, these can't
change but some servers send wrong values.

This comment seems incomplete now.

In fact, I'd be pretty surprised to see this list of prefixes in code without
reading this bug first.

Some things to explain would be: (1) entity header fields should not be sent
with 304 responses, but when they are, we ignore them, and (2) per RFC 2612
paragraph 7.1, all extension header fields are treated as entity header fields,
and (3) why we have specific prefixes instead of just "x-".

Possibly fourth thing to explain, or maybe a flaw with this patch: why are
other entity headers not here, namely Expires and Last-Modified?