[webkit-reviews] review granted: [Bug 107777] Split each RuleSet and feature out from StyleResolver into its own class. : [Attachment 186540] Fix build errors.

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 107777: Split each RuleSet and feature out from StyleResolver into its own
class.
https://bugs.webkit.org/show_bug.cgi?id=107777

Attachment 186540: Fix build errors.
https://bugs.webkit.org/attachment.cgi?id=186540&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186540&action=review


> Source/WebCore/css/DocumentRuleSets.cpp:11
> + * Copyright (C) 2012 Google Inc. All rights reserved.

2013? :)

> Source/WebCore/css/DocumentRuleSets.h:54
> +    void initUserStyle(DocumentStyleSheetCollection*, const
MediaQueryEvaluator&, StyleResolver&);

Should this just be a constructor with resetAuthorStyle in it?

> Source/WebCore/css/DocumentRuleSets.h:55
> +    void resetAuthorStyle();

This makes me wonder if author styles should sit by themselves, since they are
the only ones that are mutable in this bunch.

> Source/WebCore/css/DocumentRuleSets.h:59
> +    void collectRulesFromUserStyleSheets(const Vector<RefPtr<CSSStyleSheet>
>&, RuleSet& userStyle, const MediaQueryEvaluator&, StyleResolver&);

This can be private, right?