[webkit-reviews] review granted: [Bug 108947] Web Inspector: show whitespace characters in DTE : [Attachment 186632] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 108947: Web Inspector: show whitespace characters in DTE
https://bugs.webkit.org/show_bug.cgi?id=108947

Attachment 186632: Patch
https://bugs.webkit.org/attachment.cgi?id=186632&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186632&action=review


> Source/WebCore/English.lproj/localizedStrings.js:393
> +localizedStrings["Show whitespaces"] = "Show whitespaces";

Show whitespace

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1411
> +	   if (!visibleTo) {

no {} around single line block

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2022
> +	       var cssClass = ranges[i].token ? "webkit-" + ranges[i].token :
"";

Will this work for tab character? Note that it can be of different size.