[webkit-reviews] review requested: [Bug 108411] TextAutosizing: adjust the maximum difference between cluster text width and its descendant width : [Attachment 186618] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 09:31:51 PST 2013


Anton Vayvod <avayvod at chromium.org> has asked  for review:
Bug 108411: TextAutosizing: adjust the maximum difference between cluster text
width and its descendant width
https://bugs.webkit.org/show_bug.cgi?id=108411

Attachment 186618: Patch
https://bugs.webkit.org/attachment.cgi?id=186618&action=review

------- Additional Comments from Anton Vayvod <avayvod at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186618&action=review


>> Source/WebCore/ChangeLog:12
>> +	    each time the width difference is not greater than 50px from the
previous one. This allows
> 
> these are pixels in CSS units right?

Yes, clarified.

>> Source/WebCore/rendering/TextAutosizer.cpp:273
>> +	    const float maxWidthDifferenceDifference = 50;
> 
> DifferenceDifference... not really clear...
> 
> maxDifferenceFromWidthDifference or differenceFromMaxWidthDifference...

The latter. Done.


More information about the webkit-reviews mailing list