[webkit-reviews] review granted: [Bug 108919] [V8] Remove deprecatedV8String() and deprecatedV8Integer() : [Attachment 186566] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 5 09:31:19 PST 2013
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 108919: [V8] Remove deprecatedV8String() and deprecatedV8Integer()
https://bugs.webkit.org/show_bug.cgi?id=108919
Attachment 186566: Patch
https://bugs.webkit.org/attachment.cgi?id=186566&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186566&action=review
>> Source/WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h:45
>> class V8CustomXPathNSResolver : public XPathNSResolver {
>
> BTW, the implementation of V8CustomXPathNSResolver looks weird. The class
exists just for keeping m_resolver. Alternately, we might want to store
m_resolver to a ScriptState and pass the ScriptState around WebCore and JSC/V8
bindings. Then we can remove V8CustomXPathNSResolver and
JSCustomXPathNSResolver.
Yes, I suspect that we have more modern tools for handling this case these
days.
More information about the webkit-reviews
mailing list