[webkit-reviews] review granted: [Bug 106669] [Qt] Switch to GStreamer 1.0 : [Attachment 182351] Switch QtWebKit to GStreamer 1.0

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Sebastian Dröge
<slomo at circular-chaos.org>'s request for review:
Bug 106669: [Qt] Switch to GStreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=106669

Attachment 182351: Switch QtWebKit to GStreamer 1.0
https://bugs.webkit.org/attachment.cgi?id=182351&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182351&action=review


r=me with minor changes mentioned inline, but we should wait with landing until
bots upgrade.

>> Source/WebCore/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.	[whitespace/tab] [5]

Please remove this line.

>> Source/WebCore/WebCore.pri:169
>> +	DEFINES += GST_API_VERSION=1.0
> 
> That one is not needed I think.

I agree, we don't need it.

>> Tools/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.	[whitespace/tab] [5]

Please remove this line.