[webkit-reviews] review denied: [Bug 108832] [WK2][EFL] Set up NetworkProcess : [Attachment 186403] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 06:24:13 PST 2013


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 108832: [WK2][EFL] Set up NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=108832

Attachment 186403: Patch
https://bugs.webkit.org/attachment.cgi?id=186403&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186403&action=review


> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:64
> +#if PLATFORM(GTK)
> +#define SOCKET_TYPE SOCK_STREAM
> +#else
> +#define SOCKET_TYPE SOCK_DGRAM
> +#endif

Guess a GTK guy should review this. But why the difference? comment?

> Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:27
> +
> +#ifndef RemoteNetworkingContext_h
> +#define RemoteNetworkingContext_h

if you move things around, maybe that should be a separate patch with good
reasoning for doing so

> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:65
> +#if PLATFORM(EFL)
> +    if (!eina_init())
> +	   return 1;
> +    if (!ecore_init()) {
> +	   // Could not init ecore.
> +	   eina_shutdown();
> +	   return 1;
> +    }
> +#endif

So why does the networking process need EFL stuff, when we basically just use
libsoup for networking? Why not just use glib+libsoup and share this with GTK?


More information about the webkit-reviews mailing list