[webkit-reviews] review granted: [Bug 108920] [Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate : [Attachment 186567] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 108920: [Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=108920

Attachment 186567: Patch
https://bugs.webkit.org/attachment.cgi?id=186567&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186567&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:327
> +    {
> +	   WKPageFindClient findClient;
> +	   memset(&findClient, 0, sizeof(WKPageFindClient));
> +	   findClient.version = kWKPageFindClientCurrentVersion;
> +	   findClient.clientInfo = this;
> +	   findClient.didFindString = didFindString;
> +	   findClient.didFailToFindString = didFailToFindString;
> +	   WKPageSetPageFindClient(toAPI(webPageProxy.get()), &findClient);
> +    }

If the intent is to do so with most C API clients, it would be cleaner move all
their initialization in a separate method.
We can also do this once we have more of them here.
r=me either way.