[webkit-reviews] review granted: [Bug 108776] Web Inspector: prevent crash, add required error string value : [Attachment 186586] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 5 05:29:47 PST 2013
Pavel Feldman <pfeldman at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 108776: Web Inspector: prevent crash, add required error string value
https://bugs.webkit.org/show_bug.cgi?id=108776
Attachment 186586: Patch
https://bugs.webkit.org/attachment.cgi?id=186586&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186586&action=review
> Source/WebCore/inspector/PageRuntimeAgent.cpp:140
> + // FIXME(code.review): correct or confirm the message.
Please remove this fixme.
> Source/WebCore/inspector/PageRuntimeAgent.cpp:141
> + *errorString = "Main world execution context not found.";
"Internal error: main world execution context not found." ?
More information about the webkit-reviews
mailing list