[webkit-reviews] review granted: [Bug 108726] Call XSSAuditor's didBlockScript() for the threaded HTML parser : [Attachment 186454] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 108726: Call XSSAuditor's didBlockScript() for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108726

Attachment 186454: Patch
https://bugs.webkit.org/attachment.cgi?id=186454&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186454&action=review


> Source/WebCore/html/parser/CompactHTMLToken.h:102
> +// This is required for a struct with OwnPtr. We know CompactHTMLToken is
simple enough that
> +// initializing to 0 and moving with memcpy (and then not destructing the
original) will work.
> +template<> struct VectorTraits<WebCore::CompactHTMLToken> :
SimpleClassVectorTraits { };

If you have this declaration, do you need the CompactHTMLToken copy
constructor?  If not, we should remove it.