[webkit-reviews] review granted: [Bug 108882] [Mac] Captions menu should indicate language and type of track : [Attachment 186525] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 108882: [Mac] Captions menu should indicate language and type of track
https://bugs.webkit.org/show_bug.cgi?id=108882

Attachment 186525: Patch
https://bugs.webkit.org/attachment.cgi?id=186525&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186525&action=review


> Source/WebCore/page/CaptionUserPreferencesMac.mm:439
> +    if (track->kind() != track->subtitlesKeyword()) {

Shouldn't this test to see if it *is* a caption track instead?