[webkit-reviews] review denied: [Bug 108858] Store the language internally instead of using lang attribute for WebVTT nodes : [Attachment 186498] Proposed fix 0.2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dima Gorbik <dgorbik at apple.com>'s
request for review:
Bug 108858: Store the language internally instead of using lang attribute for
WebVTT nodes
https://bugs.webkit.org/show_bug.cgi?id=108858

Attachment 186498: Proposed fix 0.2
https://bugs.webkit.org/attachment.cgi?id=186498&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186498&action=review


> Source/WebCore/dom/Element.cpp:2156
> -AtomicString Element::computeInheritedLanguage() const
> +AtomicString Element::elementLanguage() const

Please don't rename this function. The name 'compute' indicates this function
is not a simple getter and needs higher cost.

> Source/WebCore/html/track/WebVTTElement.h:81
> +    AtomicString language;

m_language