[webkit-reviews] review granted: [Bug 108870] Rationalize the use of iOS/Mac #defines in Assertions.cpp : [Attachment 186478] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 108870: Rationalize the use of iOS/Mac #defines in Assertions.cpp
https://bugs.webkit.org/show_bug.cgi?id=108870

Attachment 186478: Patch
https://bugs.webkit.org/attachment.cgi?id=186478&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186478&action=review


r=me with USE(APPLE_SYSTEM_LOG) and considering whether we want USE(CF) &&
!PLATFORM(WIN).

> Source/WTF/wtf/Assertions.cpp:48
> -#if PLATFORM(MAC)
> +#if USE(CF)

I believe this will compile on Windows as well.  Do we know if we want that? 
If not:

#if USE(CF) && !PLATFORM(WIN)

> Source/WTF/wtf/Assertions.cpp:51
> +#define USE_APPLE_SYSTEM_LOG

We should use this so we can use USE(APPLE_SYSTEM_LOG) later in the file:

#define USE_APPLE_SYSTEM_LOG 1

> Source/WTF/wtf/Assertions.cpp:83
> -#if PLATFORM(MAC)
> +#if USE(CF)

Ditto.

> Source/WTF/wtf/Assertions.cpp:100
> +#if defined(USE_APPLE_SYSTEM_LOG)

#if USE(APPLE_SYSTEM_LOG)

> Source/WTF/wtf/Assertions.cpp:111
> +#if defined(USE_APPLE_SYSTEM_LOG)

#if USE(APPLE_SYSTEM_LOG)