[webkit-reviews] review granted: [Bug 108868] DFG should have a precise view of jump targets : [Attachment 186476] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 108868: DFG should have a precise view of jump targets
https://bugs.webkit.org/show_bug.cgi?id=108868

Attachment 186476: the patch
https://bugs.webkit.org/attachment.cgi?id=186476&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186476&action=review


Looks fine, my only concern is whether std::sort is guaranteed to not be a
stupid quick sort

> Source/JavaScriptCore/bytecode/PreciseJumpTargets.cpp:116
> +    std::sort(out.begin(), out.end());

How well does std::sort work on mostly ordered data?