[webkit-reviews] review granted: [Bug 108861] WebProcess crashes handling repeated NetworkProcess crashes : [Attachment 186464] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 108861: WebProcess crashes handling repeated NetworkProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=108861

Attachment 186464: Patch v1
https://bugs.webkit.org/attachment.cgi?id=186464&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186464&action=review


> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:135
> +    ASSERT(m_interallyFailedResourceLoaders.isEmpty());

This does not look certain to me. Can't didFail() calls execute JavaScript,
which will start new loaders that will fail?

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.h:71
> +    HashSet<RefPtr<WebCore::ResourceLoader> >
m_interallyFailedResourceLoaders;
> +    WebCore::RunLoop::Timer<WebResourceLoadScheduler>
m_interallyFailedLoadTimer;

Typos: should be "internally".