[webkit-reviews] review granted: [Bug 108856] Allow TextTracks to be marked as closed captions : [Attachment 186455] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 14:12:38 PST 2013

Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 108856: Allow TextTracks to be marked as closed captions

Attachment 186455: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186455&action=review

A little strange to land just the patch that adds the data, but OK if you will
follow up soon.

> Source/WebCore/html/track/TextTrack.cpp:110
> +    , m_closedCaption(false)

Should be named m_isClosedCaption.

> Source/WebCore/html/track/TextTrack.h:113
> +    void setIsClosedCaption(bool c) { m_closedCaption = c; }

I’d name the local variable “isClosedCaption” rather than c.

More information about the webkit-reviews mailing list