[webkit-reviews] review granted: [Bug 108589] REGRESSION (r137607): Loading of archives as substitute data is broken : [Attachment 186438] Fix in MainResourceLoader

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 108589: REGRESSION (r137607): Loading of archives as substitute data is
broken
https://bugs.webkit.org/show_bug.cgi?id=108589

Attachment 186438: Fix in MainResourceLoader
https://bugs.webkit.org/attachment.cgi?id=186438&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186438&action=review


It seems wasteful to copy all the data. Is there a way to redesign the storage
to avoid such copying?

> Source/WebCore/loader/MainResourceLoader.cpp:213
> +    if (m_substituteData.isValid())
> +	   return ResourceBuffer::create(m_substituteData.content()->data(),
m_substituteData.content()->size());
>      return m_resource ? m_resource->resourceBuffer() : 0;

I'd have written this differently, putting common case first. But this is OK
too.