[webkit-reviews] review granted: [Bug 108842] Add specific EditActions for Bold and Italic commands. : [Attachment 186433] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 12:23:45 PST 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 108842: Add specific EditActions for Bold and Italic commands.
https://bugs.webkit.org/show_bug.cgi?id=108842

Attachment 186433: Patch
https://bugs.webkit.org/attachment.cgi?id=186433&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186433&action=review


r=me provided it builds everywhere.

> Source/WebCore/ChangeLog:9
> +	   No new tests. No behavior change.

We should explain why we're making this change.

> Source/WebKit2/ChangeLog:21
> +2013-02-04  Enrica Casucci  <enrica at apple.com>
> +
> +	   Add iOS specific EditActions.
> +	   https://bugs.webkit.org/show_bug.cgi?id=108842.
> +	   <rdar://problem/13098252>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * UIProcess/WebEditCommandProxy.cpp:
> +	   (WebKit::WebEditCommandProxy::nameForEditAction):

Double change logs.


More information about the webkit-reviews mailing list