[webkit-reviews] review granted: [Bug 108783] Update CaptionUserPreferences : [Attachment 186420] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 11:31:52 PST 2013


Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 108783: Update CaptionUserPreferences
https://bugs.webkit.org/show_bug.cgi?id=108783

Attachment 186420: Updated patch
https://bugs.webkit.org/attachment.cgi?id=186420&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186420&action=review


> Source/WebCore/page/CaptionUserPreferencesMac.mm:95
> -
> +    

Nit: indent added?

> Source/WebCore/page/CaptionUserPreferencesMac.mm:185
> +	   builder.append(" !important");

Technically I don't think you need the space before the "!", but it doesn't
hurt.


More information about the webkit-reviews mailing list