[webkit-reviews] review granted: [Bug 108729] Allow TiledCoreAnimationDrawingArea overlay layers to become tiled : [Attachment 186197] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 11:14:58 PST 2013


Anders Carlsson <andersca at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 108729: Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
https://bugs.webkit.org/show_bug.cgi?id=108729

Attachment 186197: patch
https://bugs.webkit.org/attachment.cgi?id=186197&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186197&action=review


> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:347
> +    if (m_pageOverlayLayer)
> +	   if (TiledBacking* tiledBacking = m_pageOverlayLayer->tiledBacking())

> +	       tiledBacking->setExposedRect(exposedRect);

Outer if statement should have braces.

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:356
> +    if (m_pageOverlayLayer)
> +	   if (TiledBacking* tiledBacking = m_pageOverlayLayer->tiledBacking())

> +	       tiledBacking->setClipsToExposedRect(!isScrollable);

Outer if statement should have braces.


More information about the webkit-reviews mailing list