[webkit-reviews] review granted: [Bug 108741] Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals : [Attachment 186207] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 09:38:44 PST 2013


Tony Chang <tony at chromium.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 108741: Kill suspendAnimation(), resumeAnimation() and
numberOfActiveAnimations() from DRT/WTR; use Internals
https://bugs.webkit.org/show_bug.cgi?id=108741

Attachment 186207: Patch
https://bugs.webkit.org/attachment.cgi?id=186207&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186207&action=review


Looks like you need to update some exports.

> Source/WebCore/testing/Internals.cpp:417
> +void Internals::suspendAnimations(Document* document, ExceptionCode& ec)
const

It would be nice to drop the document parameter, but doing that as a separate
change would also be OK.


More information about the webkit-reviews mailing list