[webkit-reviews] review denied: [Bug 108803] Web Inspector: Native Memory Instrumentation: fix the instrumentation of GraphicsLayers : [Attachment 186319] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 08:50:15 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 108803: Web Inspector: Native Memory Instrumentation: fix the
instrumentation of GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=108803

Attachment 186319: Patch
https://bugs.webkit.org/attachment.cgi?id=186319&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186319&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:2902
> -    info.addWeakPointer(m_renderView);
> +    info.addMember(m_renderView, "renderView");

It's not clear to me that this is correct. RenderView is a "back pointer"; it's
not owned by RLC.


More information about the webkit-reviews mailing list