[webkit-reviews] review canceled: [Bug 108794] [EFL][WK2] Stop using WebString in ewk_cookie_manager, ewk_form_submission_request and ewk_text_checker : [Attachment 186383] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has canceled Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 108794: [EFL][WK2] Stop using WebString in ewk_cookie_manager,
ewk_form_submission_request and ewk_text_checker
https://bugs.webkit.org/show_bug.cgi?id=108794

Attachment 186383: Patch
https://bugs.webkit.org/attachment.cgi?id=186383&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186383&action=review


>> Source/WebKit2/UIProcess/API/cpp/efl/WKEinaSharedString.h:49
>> +	const char* leakString();
> 
> think it should return Eina_Stringshare*

Yes, it is clearer. I'll update. BTW, we use const char* when we mean
Eina_Stringshare* in a lot of places. We should probably fix that.