[webkit-reviews] review granted: [Bug 108818] [v8] explicit isolate parameter for MakeWeak calls : [Attachment 186357] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Dan Carney
<dcarney at google.com>'s request for review:
Bug 108818: [v8] explicit isolate parameter for MakeWeak calls
https://bugs.webkit.org/show_bug.cgi?id=108818

Attachment 186357: Patch
https://bugs.webkit.org/attachment.cgi?id=186357&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review


> Source/WebCore/bindings/v8/DOMDataStore.cpp:43
> +    , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent
twice.

TODO =>　FIXME

> Source/WebCore/bindings/v8/DOMWrapperMap.h:108
> +    v8::NearDeathCallback m_callback;

NearDeathCallback is a good name!