[webkit-reviews] review granted: [Bug 108073] Web Inspector: Allow user to change dock side by dragging toolbar : [Attachment 185748] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 108073: Web Inspector: Allow user to change dock side by dragging toolbar
https://bugs.webkit.org/show_bug.cgi?id=108073

Attachment 185748: Patch
https://bugs.webkit.org/attachment.cgi?id=185748&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185748&action=review


Looks good! Please fix the style nits and reattach for automated landing!

> Source/WebCore/inspector/front-end/Toolbar.js:158
> +	   else if (Preferences.showDockToRight)

Remove "else"

> Source/WebCore/inspector/front-end/Toolbar.js:160
> +	   else

ditto

> Source/WebCore/inspector/front-end/Toolbar.js:170
> +	   // We cannot call window.moveBy here because it restricts the
movement

Just remove this comment...