[webkit-reviews] review requested: [Bug 108799] [CPP, GObj, ObjC] Add checks for unsupported Web IDL features, remove #if V8/JS : [Attachment 186336] First draft
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 4 03:31:00 PST 2013
Nils Barth <nbarth at google.com> has asked for review:
Bug 108799: [CPP,GObj,ObjC] Add checks for unsupported Web IDL features, remove
#if V8/JS
https://bugs.webkit.org/show_bug.cgi?id=108799
Attachment 186336: First draft
https://bugs.webkit.org/attachment.cgi?id=186336&action=review
------- Additional Comments from Nils Barth <nbarth at google.com>
Makes changes as described in Description/first comment.
Changes are quite simple, but there are a lot of them,
so I've put details in ChangeLog.
I don't believe that the changes make the CodeGenerators skip any
code they can legitimately generate, so shouldn't change existing generated
code (or if it does, existing bindings may be broken), but someone
more familiar with them may want to check.
BTW, the check-webkit-style failures are b/c CodeGeneratorGObject.pm
generates non-compliant code for g_object_class_install_property
(unrelated issue).
More information about the webkit-reviews
mailing list