[webkit-reviews] review denied: [Bug 108692] Web Inspector: add round braces to javascript tokenizer : [Attachment 186149] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 2 03:56:58 PST 2013

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 108692: Web Inspector: add round braces to javascript tokenizer

Attachment 186149: Patch

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186149&action=review

> Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:-180
> -		   <DIV,NODIV> RightParen => DIV { this.tokenType = null;
return cursor; }

DIV,NODIV => DIV means that we transition from the state where division is
expected or not expected into the state where it is expected (this is due to
"/" ambiguity - it might be division or regex start).

More information about the webkit-reviews mailing list