[webkit-reviews] review denied: [Bug 108725] [Chromium] Add a signal for when the body is inserted in the document : [Attachment 186198] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 108725: [Chromium] Add a signal for when the body is inserted in the
document
https://bugs.webkit.org/show_bug.cgi?id=108725

Attachment 186198: Patch
https://bugs.webkit.org/attachment.cgi?id=186198&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186198&action=review


> Source/WebCore/html/HTMLBodyElement.cpp:190
> +    if (Frame* frame = document()->frame())
> +	   frame->loader()->client()->dispatchDidInsertBody();

This is wrong.	It will fire every time a body element is inserted anywhere,
regardless of whether it's document.body.

Instead what you want is a notification at the end of
HTMLConstructionSite::insertHTMLBodyElement