[webkit-reviews] review denied: [Bug 103561] Allow client to monitor event listeners added and removed of a certain type : [Attachment 186122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 2 00:00:09 PST 2013


Adam Barth <abarth at webkit.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 103561: Allow client to monitor event listeners added and removed of a
certain type
https://bugs.webkit.org/show_bug.cgi?id=103561

Attachment 186122: Patch
https://bugs.webkit.org/attachment.cgi?id=186122&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186122&action=review


> Source/WebCore/ChangeLog:10
> +	   BrowserPlugin needs to be able to observe event listeners attached
to it
> +	   so that it can enable window.open when event listeners are attached
to the
> +	   'newwindow' event.

That doesn't sound like a good API.  Adding event listeners should not produce
side effects.


More information about the webkit-reviews mailing list